Skip to content

GitLab

T
tangled
Switch branch/tag
Find file BlameHistoryPermalink
  • leviw@chromium.org's avatar
    Fix zero height root renderer with background image painting · 7af140a3
    leviw@chromium.org authored 
    When the root renderer is fully collapsed with a background
image, the solid color background painting path would assume
that the background image would fill the viewport, but the
background image code would, correctly, only use the actual
height of the root and therefor not fill anything. The
result is the viewport isn't filled at all.

This is a regression from my early patch (r166582) that avoids
implicitly painting the viewport background when the root
itself will do so as an optimization to avoid rasterizing the entire
viewport twice. Catching the case in the solid color background
painting path. Behavior matches FireFox and Safari.

BUG=349936

Review URL: https://codereview.chromium.org/208393004

git-svn-id: svn://svn.chromium.org/blink/trunk@169889 bbb929c8-8fbe-4397-9dbb-9b2b20218538
    7af140a3
root-with-generated-background-and-no-height.html 135 Bytes