• Peter Wen's avatar
    Android: Generate project.xml for lint · 7b39bed1
    Peter Wen authored
    Use --project to pass in a generated project.xml file for each lint
    target instead of passing each argument through the command line. This
    allows the lint checks to function more correctly and thoroughly than
    before.
    
    Currently lint does not fully support srcjars (fix is in ToT but not yet
    in our lint version), so we extract generated sources and generated
    resources in a consistent temporary location under their lint target's
    gen dir, removing them if lint succeeds and leaving them in place if
    lint fails in order to make it easier to debug lint failures.
    
    Clean up and remove various options that are no longer used or needed.
    e.g. display lint errors directly rather than parsing an xml file from
    lint's results.
    
    Simplify suppressions file comments and remove unnecessary ones. Ignore
    common failures for translations since we have a dedicated translation
    team.
    
    Remove an unused dimens and fix a few issues. Suppress additional issues
    found by this lint improvement.
    
    Bug: 1082743
    Change-Id: I67147e582bd904308fe6a5fc5a11baebd60db41b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212550
    Commit-Queue: Peter Wen <wnwen@chromium.org>
    Reviewed-by: default avatarTheresa  <twellington@chromium.org>
    Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
    Auto-Submit: Peter Wen <wnwen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#772301}
    7b39bed1
lint.py 13.6 KB