• Eric Karl's avatar
    Revert "Logging to ensure that non-offscreen surfaces are destroyed as expected" · 7b9fe37f
    Eric Karl authored
    This reverts commit a569f96f.
    
    Reason for revert: This CL was designed to detect a potential clean-up race. Race not detected, so reverting.
    
    
    Original change's description:
    > Logging to ensure that non-offscreen surfaces are destroyed as expected
    > 
    > We're hitting scenarios where it appears that we may be creating an
    > EGL window surface for a given window before destroying the previous.
    > This leads to errors on Android, and shouldn't be possible. We're
    > suspecting that someone may be taking a reference on the glSurface,
    > extending the lifetime beyond the expected range. This CL adds logging
    > to catch this scenario.
    > 
    > Bug: 787086
    > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    > Change-Id: I31bb0c55fb393a0719486f32f885273ee81ab9f8
    > Reviewed-on: https://chromium-review.googlesource.com/802186
    > Commit-Queue: Eric Karl <ericrk@chromium.org>
    > Reviewed-by: Bo <boliu@chromium.org>
    > Reviewed-by: Antoine Labour <piman@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#522293}
    
    TBR=boliu@chromium.org,piman@chromium.org,ericrk@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 787086
    Change-Id: Ib921aa04c7a3589b514b4b14091989d368cf2202
    Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/820111Reviewed-by: default avatarEric Karl <ericrk@chromium.org>
    Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
    Commit-Queue: Bo <boliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#523295}
    7b9fe37f
gles2_cmd_decoder.cc 746 KB