• Roberto Carrillo's avatar
    Revert "Fix missing dependencies with RLZ target." · 7bde422c
    Roberto Carrillo authored
    This reverts commit 22333d92.
    
    Reason for revert: suspected of breakage in 'generate_build_files': https://bugs.chromium.org/p/chromium/issues/detail?id=870827#c3
    
    Original change's description:
    > Fix missing dependencies with RLZ target.
    > 
    > chrome_rlz_tracker_delegate.cc depended on browser_process.h which had transitive dependencies on generated mojoms. But it didn't get the public_deps because the rlz target didn't depend on chrome/browser to avoid circular dependencies. Fold it into chrome/browser to fix this properly.
    > 
    > This does mean that the one unit test in chrome_rlz_tracker_delegate_unittest.cc
    >  will not run on chromium-branded bots anymore. That seems better than having flaky dependencies, since untangling the build dependencies looks like a lot of work.
    > 
    > Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
    > Change-Id: I85d78d25b1905c68524e0636cec3006102d17749
    > Reviewed-on: https://chromium-review.googlesource.com/1161610
    > Reviewed-by: Avi Drissman <avi@chromium.org>
    > Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#580579}
    
    TBR=avi@chromium.org,jam@chromium.org
    
    Change-Id: I5bca5200d639f01dbba1ed582d9dccb3290cf0c4
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
    Reviewed-on: https://chromium-review.googlesource.com/1162211Reviewed-by: default avatarRoberto Carrillo <robertocn@chromium.org>
    Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#580660}
    7bde422c
check_gn_headers_whitelist.txt 16.4 KB