• Patrick Noland's avatar
    [ToolbarMVC] Use MenuButton in CustomTabToolbar · 7bf9f7b9
    Patrick Noland authored
    Current CCToolbar uses a bare ImageButton instead of MenuButton. In the
    linked bugs, this causes us to fail to connect the button with the
    AppMenuButtonHelper and leaves the menu un-anchored. Rather than writing
    special logic to set the AppMenuButtonHelper for the bare image button,
    it seems cleaner to just use MenuButton on the CCToolbar and have it be
    safe/correct to use in that scenario (no update badge).
    
    Bug:1125048,1125075
    
    Change-Id: I041a95467252d64af9559e40342c424645983e4b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399315
    Commit-Queue: Patrick Noland <pnoland@chromium.org>
    Reviewed-by: default avatarMatthew Jones <mdjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#805346}
    7bf9f7b9
custom_tabs_toolbar.xml 5.58 KB