• Ken Rockot's avatar
    Re-enable WebRequestApiTest.WebRequestClientsGoogleComProtection · 7c2240a7
    Ken Rockot authored
    Re-enables this test with the Network Service enabled.
    
    This test did some things which the Network Service does not support and
    does not need to support, or which otherwise made testing with the
    Network Service more complex than necessary. The following changes have
    been made:
    
      * We no longer attempt to load a network resource from a WebUI
        renderer. This will not be supported with Network Service and is no
        longer desirable to have working in production anyway. There should
        no longer be any WebUI pages making network requests.
    
      * Use http instead of https for the clients1.google.com requests. This
        allows such requests to be handled by the EmbeddedTestServer which
        already exists in BrowserTestBase, which is itself not configured to
        handle HTTPS requests. Since these requests are filtered by
        hostname, the scheme doesn't matter.
    
      * Switch the test to use a SimpleURLLoader instead of a
        FakeURLFetcher. This allows the test code to exercise the same
        behavior with or without the Network Service enabled.
    
    Bug: 721414
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
    Change-Id: Iad1f2deaec2e218b9cb168acbe71c90591dc6acf
    Reviewed-on: https://chromium-review.googlesource.com/972425
    Commit-Queue: Ken Rockot <rockot@chromium.org>
    Reviewed-by: default avatarKaran Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#548137}
    7c2240a7
web_request_permissions.h 2.61 KB