• Leonard Grey's avatar
    Close bookmark menus before executing 'Open All' · 7c6430c1
    Leonard Grey authored
    When a user command-clicks on a nested bookmark bar folder to open all,
    we pop up a dialog to ask if they're sure if the number of tabs that
    would be opened exceeds some minimum. Currently, we do this *before*
    we dismiss the menu, which (at least on the Mac) closes on a later run
    loop as the result of a focus change.
    
    This causes some issues on Mac, including a mouse capture induced
    crash and accessibility inconsistencies (see bug for both).
    
    This change disables the code that keeps the bookmark menu open on
    background open if the node is a folder.
    
    Bug: 1105587
    Change-Id: Iba0ffb0746a9caab0484df22ab40f49ef554ff2b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299530
    Commit-Queue: Leonard Grey <lgrey@chromium.org>
    Reviewed-by: default avatarPeter Boström <pbos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#789490}
    7c6430c1
bookmark_menu_delegate.cc 21.9 KB