• Cliff Smolinsky's avatar
    Omnibox: Fix OnBlur RevertAll behavior for NTP · 7d0d820f
    Cliff Smolinsky authored
    Recent changes to the handling of user_input_in_progress caused a
    regression in OmniboxViewViews::OnBlur() where the edit state is not
    reverted when the current text exactly matches the permanent text. This
    resulted in page icons such as the bookmarks star from remaining hidden
    when they should be shown.
    
    This change adds a check to see whether the text has been edited but
    currently is an exact match for the permanent text and does a revert.
    This is necessary because users may have no idea that they are
    currently in "edit mode" because the text looks unchanged.
    
    Bug: 932782
    Change-Id: Ie6d7218daa27a4f59eafaac9c76477925b50e384
    Reviewed-on: https://chromium-review.googlesource.com/c/1475947
    Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com>
    Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#633788}
    7d0d820f
omnibox_view_views.cc 63.9 KB