• Jan Wilken Dörrie's avatar
    Reland "Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"" · 7dd23fd6
    Jan Wilken Dörrie authored
    This reverts commit b050a38a.
    
    Reason for revert: https://crrev.com/c/1161883 fixes the device_unittests breakage triggered by this CL.
    
    Original change's description:
    > Revert "Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors""
    > 
    > This reverts commit be2632ac.
    > 
    > Reason for revert: Broke device_unittests on Win10 Tests x64 (dbg) crbug.com/870208
    > 
    > Original change's description:
    > > Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"
    > > 
    > > This reverts commit 67ca5a07.
    > > 
    > > Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change.
    > > 
    > > Original change's description:
    > > > Revert "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"
    > > > 
    > > > This reverts commit 20f64257.
    > > > 
    > > > Reason for revert: Suspected of breaking device_unittests on Win10 Tests x64 (dbg)
    > > > 
    > > > Original change's description:
    > > > > [Bluetooth][WinRT] Implement Obtaining Gatt Descriptors
    > > > > 
    > > > > This change implements obtainining Remote Gatt Descriptors for WinRT by
    > > > > hooking up the appropriate logic into GattDiscovererWinrt. Furthermore,
    > > > > appropriate tests are enabled.
    > > > > 
    > > > > Bug: 821766
    > > > > Change-Id: I20475478367c2ab6b18940b4271de70ec138f676
    > > > > Reviewed-on: https://chromium-review.googlesource.com/1156392
    > > > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    > > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    > > > > Reviewed-by: Reilly Grant <reillyg@chromium.org>
    > > > > Cr-Commit-Position: refs/heads/master@{#579830}
    > > > 
    > > > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org
    > > > 
    > > > Change-Id: If5128ebf0c9dd1f585bd98b9729a57340f4493a0
    > > > No-Presubmit: true
    > > > No-Tree-Checks: true
    > > > No-Try: true
    > > > Bug: 821766, 870208
    > > > Reviewed-on: https://chromium-review.googlesource.com/1159943
    > > > Reviewed-by: Christos Froussios <cfroussios@chromium.org>
    > > > Commit-Queue: Christos Froussios <cfroussios@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#580106}
    > > 
    > > TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org
    > > 
    > > Change-Id: I8a4e456fe6d3b63c9d9b02c15ecdd35ac61a7fa7
    > > No-Presubmit: true
    > > No-Tree-Checks: true
    > > No-Try: true
    > > Bug: 821766, 870208
    > > Reviewed-on: https://chromium-review.googlesource.com/1160901
    > > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#580200}
    > 
    > TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org
    > 
    > Change-Id: I9bd3f94b1be3b58b7975e1e57dff09cd7a9c2910
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 821766, 870208
    > Reviewed-on: https://chromium-review.googlesource.com/1161682
    > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
    > Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#580442}
    
    TBR=reillyg@chromium.org,ksakamoto@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 821766, 870208
    Change-Id: I29824289cbd23722a5e0397f07f40b62769549d4
    Reviewed-on: https://chromium-review.googlesource.com/1163382Reviewed-by: default avatarJan Wilken Dörrie <jdoerrie@chromium.org>
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#580828}
    7dd23fd6
fake_gatt_device_service_winrt.cc 5.6 KB