• Luciano Pacheco's avatar
    Fix some more with flag MyFilesVolume enabled · 7dd3be88
    Luciano Pacheco authored
    Change EntryList method from children to use getUIChildren so it has
    the same API as VolumeEntry.
    
    Change util.isDescendantEntry to check getUIChildren for EntryList and
    VolumeEntry if the filesystem of both entris are different. These 2
    types contain entries with different filesystem thus we should check
    those.
    
    Add toEntryList helper just to be able to check that an entry has the
    method getUIChildren without closure complaining that Entry and
    FilesAppEntry don't have such attribute, this method is only available
    in EntryList and VolumeEntry.
    
    Change directory_tree EntryListItem to add the volume type attribute
    to have it compatible with and without MyFilesVolume flag.
    
    Change file_display.js selector to use volume-type-icon makes downloads
    folder selector compatible with/without MyFilesVolume flag.
    
    Change FileManager to check if MyFiles actually exist before assigning
    to nextCurrentDirEntry, this happens if MyFiles is a volume and isn't
    mounted. Also in this condition (MyFiles being a volume but not
    mounted) change NavigationListModel to create a EntryList for MyFiles
    so it can display Linux or Play files if they exist.
    
    before this change.
    
    Test: Enabled a few tests with MyFilesVolume flag that were broken
    Bug: 873539
    Change-Id: I66d2b95d5ea5897c2f2db558f46b0bcfcfd0c900
    Reviewed-on: https://chromium-review.googlesource.com/c/1345708
    Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    Reviewed-by: default avatarJoel Hockey <joelhockey@chromium.org>
    Reviewed-by: default avatarLuciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#610505}
    7dd3be88
file_manager_browsertest.cc 44.8 KB