• mpearson@chromium.org's avatar
    Omnibox: Don't Call Classify() Repeatedly · 7e3b77f5
    mpearson@chromium.org authored
    Tested:
    * Search for "qrty.com" repeatedly.  Verify that when you type "q", a search for "qrty.com" does not get inline autocompleted.  This is the same as the behavior before this changelist.  Without the Classify() code, this suppression of the inline autocompletion does not happen.
    * Check speed.  Search for "testing 1", "testing 2", ... "testing 13", ...  i.e., create a lot of searches starting with "t".  Restart browser.  Open seven blank new tabs and two separate tabs of about:histograms.  In each blank tab, type "t"; don't hit return.  Reload one of the histograms tabs.  Compare the Omnibox.ProviderTime.Search histogram in the  non-reloaded histograms tab with the reloaded histograms tab.
      - in current chrome (before this patch), I see a difference in the laggy section of the histogram.  In my testing, I see 7 new entries in the 129-204ms bucket.  Ugh.
      - in chrome built with this patch, I see a difference in the 13-21ms bucket; no different in higher buckets.
    
    BUG=393956, 262263
    
    Review URL: https://codereview.chromium.org/412063003
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285456 0039d316-1c4b-4281-b951-d872f2087c98
    7e3b77f5
search_provider.cc 51.1 KB