• Yuwei Huang's avatar
    [remoting host] Free ftl_echo_message_listener_ before signal_strategy_ · 7e4894e1
    Yuwei Huang authored
    Currently ftl_echo_message_listener_ is never explicitly freed, and it
    calls `signal_strategy_->RemoveListener(this)` in its dtor, while
    signal_strategy_ is freed in HostProcess::OnHostOfflineReasonAck. This
    causes a use-after-free issue when the ftl_echo_message_listener_ is
    explicitly freed, which means the host would crash in shutdown and soft
    restart.
    
    This CL frees ftl_echo_message_listener_ before signal_strategy_ is
    freed.
    
    Bug: 1090595
    Change-Id: Ie546a9084fdf21545ecd9158b9830cc93335ecb7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227265
    Commit-Queue: Yuwei Huang <yuweih@chromium.org>
    Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
    Auto-Submit: Yuwei Huang <yuweih@chromium.org>
    Reviewed-by: default avatarJamie Walch <jamiewalch@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#774426}
    7e4894e1
remoting_me2me_host.cc 60.5 KB