• Samuel Huang's avatar
    Reland "Fix browser menu button flood fill effect always originating from center" · 7f097e0f
    Samuel Huang authored
    This reverts commit b1d35c01.
    
    Reason for revert: Speculative revert did not fix problem.
    
    Original change's description:
    > Revert "Fix browser menu button flood fill effect always originating from center"
    > 
    > This reverts commit 25016613.
    > 
    > Reason for revert: Speculative revert for
    > virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-click-hyperlink.html
    > failure under WebKit Linux Trusty (dbg) .
    > 
    > Original change's description:
    > > Fix browser menu button flood fill effect always originating from center
    > > 
    > > The MenuButton::PressedLock used to be always created with a null
    > > event from MenuController::Run() causing it to eventually call
    > > AnimateInkDrop() with a null event, which then used to clear
    > > the inkdrop host's `last_ripple_triggering_event_` which is
    > > used as the point from which the flood fill is generated.
    > > 
    > > This CL passes the current located event (if any) to
    > > MenuButton::PressedLock.
    > > 
    > > BUG=819878
    > > 
    > > Change-Id: I4fb18ab73f60c75af3bce948f44ac41a8c6683b8
    > > Reviewed-on: https://chromium-review.googlesource.com/1089495
    > > Reviewed-by: Trent Apted <tapted@chromium.org>
    > > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#565538}
    > 
    > TBR=tapted@chromium.org,afakhry@chromium.org
    > 
    > Change-Id: Ib3c0639e217e4e62d6c8a1aa004eda721e318c4f
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 819878
    > Reviewed-on: https://chromium-review.googlesource.com/1092249
    > Reviewed-by: Samuel Huang <huangs@chromium.org>
    > Commit-Queue: Samuel Huang <huangs@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#565654}
    
    TBR=huangs@chromium.org,tapted@chromium.org,afakhry@chromium.org
    
    Change-Id: I6a7b6243c363699a3d7620190409022ba8d58a03
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 819878
    Reviewed-on: https://chromium-review.googlesource.com/1093354Reviewed-by: default avatarSamuel Huang <huangs@chromium.org>
    Commit-Queue: Samuel Huang <huangs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#565670}
    7f097e0f
menu_controller.cc 103 KB