• Devlin Cronin's avatar
    [Extensions Performance] Only record action updates for defaults · 7f7901f6
    Devlin Cronin authored
    Extensions can update the default settings of browser actions (such as
    badge text, popup url, icon, and more). These settings are persisted in
    storage across runs. However, currently the logic to persist these and
    rewrite the values in storage is being triggered even if the extension
    is only updating a specific tab's value (in which case it will just
    rewrite all the same values). This is costly, as it requires both thread
    hops and disk IO.
    
    As a first step and low-hanging fruit, ensure that we don't try to write
    the default values if the extension only updated the settings for a
    specific tab (in which case we should know that nothing in the default
    settings changed).
    
    Bug: 505676
    Change-Id: I612408740e88b76b234bf0d38433ab716485829b
    Reviewed-on: https://chromium-review.googlesource.com/768307
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: default avatarKaran Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#522152}
    7f7901f6
BUILD.gn 269 KB