-
Jeroen Dhollander authored
This DCHECK was caused because the Embedded Assistant UI tried to grab the focus while it was being closed. This |RequestFocus| call was added explicitly to fix a bug where the input text field in the Assistant UI would lose focus when submitting a query while in tablet mode. And this was happening because we tried to dismiss the virtual on-screen keyboard. I added unittests to test for these 3 scenarios, and I fixed it by dismissing the virtual keyboard using a |HideKeyboard| method instead of dismissing it by dropping the focus of the text field. Bug: b/141945964 Change-Id: I3aca9e08ab0e2b7419cfe53c1f4dc831130cd0df Tests: Added unittests and verified manually Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848796 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#707983}
7fb44f93