• simonjam@chromium.org's avatar
    Fix race between OnPipelineFeedback and · 8027e74b
    simonjam@chromium.org authored
    HttpStreamFactoryImpl::Job::OnStreamReadyCallback.
    
    As a side-effect of OnPipelineFeedback() calling OnPipelineHasCapacity() on all
    of the pipelines, some requests are late-bound to existing pipelines with
    capacity. However, those requests may have been in the process of establishing
    new pipelines. By stealing those requests, the new pipelines become empty and
    are deleted. Later iterations of the loop in OnPipelineFeedback() weren't
    careful about checking to see if the pipeline was deleted before calling
    OnPipelineHasCapacity() on it.
    
    BUG=106313
    TEST=net_unittests under valgrind
    
    
    Review URL: http://codereview.chromium.org/8820005
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113287 0039d316-1c4b-4281-b951-d872f2087c98
    8027e74b
http_pipelined_host_impl.cc 5.77 KB