GitLab

This CL has 2 goals.

1) Split EnableSyncSignOutAndChangeAccount into smaller tests so that
when the linked bug is fixed, we have a good place to put our
expectation that IsSyncRequested gets cleared on sign-out. The existing
test apparently was even testing some invalidations code [1].

2) Stop coupling StopAndClear() with sign-out in documentation/comments,
since this isn't super true nowadays. For example on Desktop, when the
user chooses to disable sync by sign-out + clear all data, the
StopAndClear() call is rather a by-product of deleting the profile [2],
not of clearing the primary account on the identity manager.

As a bonus, we update some references in comments to RequestStop(), the
old name of StopAndClear().

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1164954/52/components/browser_sync/profile_sync_service_unittest.cc#707
[2] https://source.chromium.org/chromium/chromium/src/+/a5edbb26dc14b07795e7c45fa15998a4dc7f7fad:chrome/browser/ui/webui/settings/people_handler.cc;l=706

Bug: 1147026
Change-Id: I1d9dc5af66a7e58a52d6cf0f3942db315926acfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530029
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826227}