• oshima@chromium.org's avatar
    Revert 255192 "Move TranslateManager unit tests out of the brows..." · 81efa1da
    oshima@chromium.org authored
    > Move TranslateManager unit tests out of the browser_tests target.
    > 
    > These are unit tests so they should be in the unit_tests target. A
    > TODO says this did not work before, but they appear to pass as unit
    > tests now, so this is just a code move.
    > 
    > R=sky
    > BUG=270918
    > 
    > Review URL: https://codereview.chromium.org/186063007
    
    TBR=danakj@chromium.org
    
    Test is failing on Linux memory bot. If this is passing on main waterfall, it may be due to sharding
    and this test may have some global state that previous test didn't cleanup
    
    TranslateManagerRenderViewHostTest.FetchLanguagesFromTranslateServer: 
    Xlib:  extension "RANDR" missing on display ":9".
    ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:319: Failure
    Value of: fetcher != NULL
    Actual: false
    Expected: true
    ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:319: Failure
    Value of: fetcher != NULL
    Actual: false
    Expected: true
    ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:662: Failure
    Value of: current_supported_languages.size()
    Actual: 54
    Expected: server_languages.size() - 1
    Which is: 7
    ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
    Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>
    ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:675: Failure
    Value of: is_alpha
    Actual: true
    Expected: TranslateDownloadManager::IsAlphaLanguage(lang)
    Which is: false
    ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
    Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>
    ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
    Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>
    ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
    Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>
    ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
    Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>
    ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:675: Failure
    Value of: is_alpha
    Actual: true
    Expected: TranslateDownloadManager::IsAlphaLanguage(lang)
    Which is: false
    ../../chrome/browser/translate/translate_manager_render_view_host_unittest.cc:671: Failure
    Expected: (current_supported_languages.end()) != (std::find(current_supported_languages.begin(), current_supported_languages.end(), lang)), actual: 8-byte object <A0-1F 23-17 00-00 00-00> vs 8-byte object <A0-1F 23-17 00-00 00-00>
    
    Review URL: https://codereview.chromium.org/188553002
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255312 0039d316-1c4b-4281-b951-d872f2087c98
    81efa1da
chrome_tests_unit.gypi 156 KB