• Liquan (Max) Gu's avatar
    [PaymentRequest] Remove Error View from Android · 8254b0fa
    Liquan (Max) Gu authored
    Before change:
    * With Expandable PH UI enabled, if merchant pages call
    complete("fail"), the screen would be covered under scrim and Clank
    would crash on refresh.
    * With CCT PH UI enabled, if merchant pages call complete("fail"), it
    would open Error View after closing PH UI.
    
    After change:
    The Error View is no longer shown on complete("fail").
    
    Changes:
    * remove Error View from Android Payment Request UI.
    * Tests
     * add a test to ensure http would be rejected for openWindow(url)
     * add a test to cover complete ("unknown").
    
    Bug: 1044077, 1047237, 1042892, 1045474
    
    Change-Id: I0123e163d4cd0a97d1536d5c4baefa0e646c50d4
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019922Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
    Reviewed-by: default avatarRouslan Solomakhin <rouslan@chromium.org>
    Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#737634}
    8254b0fa
expandable_payment_handler_browsertest.cc 4.67 KB