• Alexei Svitkine's avatar
    Make Mac stack traces human readable. · 82c911c3
    Alexei Svitkine authored
    Currently, if there's a crash - even in a debug build - on Mac, the
    stack trace shown on the console (or on bots) is not symbolized. This
    is because we disable this functionality when we're in the signal handler.
    
    This makes it very frustrating for developers to diagnose failures - both
    locally and on the bots. So this CL attempts to enable the symbolization.
    The idea is that it's a better default since having useful stack traces
    outweighs the risk involved in doing this.
    
    TO SHERIFFS: It is possible that this may cause failures that would
    previously crash to instead hang - and this may actually be worse than
    the current behavior. If you see something like the above, then we may
    want to revert this. I'm landing this to specifically see if we can do
    this without ill effects.
    
    BUG=
    
    Change-Id: I9cdc03e2ee098305e32c8a4f119d7df6bdf3c3e4
    Reviewed-on: https://chromium-review.googlesource.com/644142
    Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: default avatarMark Mentovai <mark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#522131}
    82c911c3
stack_trace_posix.cc 30.9 KB