• Victor Costan's avatar
    leveldb: Fix the LEVELDB_EXPORT definition in component builds. · 83659026
    Victor Costan authored
    LEVELDB_EXPORT is defined in include/leveldb/export.h, and depends on
    the definition of LEVELDB_SHARED_LIBRARY. In order for LEVELDB_EXPORT to
    be defined consistently, LEVELDB_SHARED_LIBRARY must have the same
    definition in leveldb and all targets using it.
    
    Previously, LEVELDB_SHARED_LIBRARY was only defined for component builds
    in the //third_party/leveldatabase target. This CL makes the definition
    apply to //third_party/leveldatabase dependencies as well.
    
    This CL also renames the //third_party/leveldb target to
    //third_party/leveldb_static, to clarify its purpose.
    
    The CL is associated with Bug 823071 because it blocks
    https://crrev.com/c/1201856 from landing, which is relevant to that bug.
    
    Bug: 823071
    Change-Id: I4216fa52b5f7ed9540ec63be7c16dc7150e9c766
    Reviewed-on: https://chromium-review.googlesource.com/1203876
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Reviewed-by: default avatarChris Mumford <cmumford@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#590131}
    83659026
BUILD.gn 11.3 KB