• Greg Thompson's avatar
    Revert "[mini_installer] Move the fallback reporting to InstallerError." · 836a311c
    Greg Thompson authored
    This reverts commit 44f5ba08.
    
    Reason for revert: This strategy doesn't work, so let's go back to the previous strategy. It doesn't work today, but will in an upcoming Google Update release.
    
    Original change's description:
    > [mini_installer] Move the fallback reporting to InstallerError.
    > 
    > https://crrev.com/798844 attempted to send up a signal regarding whether
    > or not the fallback temp directory was used. Unfortunately, Omaha does
    > not include the ExtraCode1 value for successful installs. It does,
    > however, send up success HRESULTS in the InstallerError value. This CL,
    > therefore, switches to that. The two values to look out for are
    > 0x00044001 and 0x00044002 (two success HRESULTS in FACILITY_ITF that
    > otherwise appear to be unused).
    > 
    > BUG=516207,1100280
    > 
    > Change-Id: I319c5dbe7162543a71465238c5320719225fa1f7
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368353
    > Auto-Submit: Greg Thompson <grt@chromium.org>
    > Commit-Queue: S. Ganesh <ganesh@chromium.org>
    > Reviewed-by: S. Ganesh <ganesh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#800584}
    
    TBR=ganesh@chromium.org,grt@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 516207
    Bug: 1100280
    Change-Id: I38f6d27904d8f822c949fb07285ae63830ce533a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374206Reviewed-by: default avatarGreg Thompson <grt@chromium.org>
    Commit-Queue: Greg Thompson <grt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#801304}
    836a311c
mini_installer.cc 37.7 KB