GitLab

This CL changes the return type of LocationProvider::StartProvider (and
related functions) from bool to void.

Currently, no-one inspects the value returned from this function, except
to pass it through to other places that don't inspect it.

Most impls always return true. The situation where an impl doesn't
always return true (LocationArbitrator) are responded-to by other means.
Specifically, LocationArbitrator provides an Error geoposition in the
case that it couldn't create any location providers.

I also opportunistically removed the unused MockLocationProvider in this
CL.

Bug: 748921
Change-Id: Iaa7903b3eecaacc0076b3c1f1cce3be86187285d
Reviewed-on: https://chromium-review.googlesource.com/722139Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509561}