• Kelvin Jiang's avatar
    [Extensions] address comments from Demetrios from CL 1340876 · 849b2f0a
    Kelvin Jiang authored
    What's been addressed:
    add private/type annotation for navigationListener_ in activity_log.js
    
    use logical css properties (margin/padding) for RTL support
    
    remove trivial/default resolve function bodies in service.js
    
    remove unnecessary type annotation (primitive type) in manager.js:100
    
    add arrow icon to "View activity log" link from details page
    
    remove excessive padding on the bottom of the activity log page,causing
    scrolling to occur despite the page not having much content
    
    Change-Id: I97bd2a77166ff212fe2204130c5c1783244053e6
    Reviewed-on: https://chromium-review.googlesource.com/c/1345075Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#611359}
    849b2f0a
md_extensions_strings.grdp 22.6 KB