• Bret Sepulveda's avatar
    Revert "[base] Fail test batches if they leak processes, under POSIX." · 84a0a6bf
    Bret Sepulveda authored
    This reverts commit 2ea83bd2.
    
    Reason for revert: Multiple failing tests on Mac ASAN, see for example https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/64426
    
    Original change's description:
    > [base] Fail test batches if they leak processes, under POSIX.
    > 
    > Under Windows and Fuchsia the TestLauncher runs test batch processes in
    > their own jobs, allowing any leaked sub-processes leaked by tests to be
    > cleaned up.
    > 
    > Under POSIX platforms each batch is run in its own process group, but the
    > group was only being kill()ed if the test batch failed or crashed.
    > 
    > TestLauncher now proactively kill()s each test batch's process group. The
    > result of the call is also checked, and the test batch marked as failed
    > unless kill() reports that the process-group was already gone.
    > 
    > Note that this will still miss processes launched into new process groups
    > by tests.
    > 
    > Bug: 1094369
    > Change-Id: If379d200953a823b2020766cda73f8cf27bfdb7f
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346388
    > Commit-Queue: Wez <wez@chromium.org>
    > Auto-Submit: Wez <wez@chromium.org>
    > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#797277}
    
    TBR=wez@chromium.org,tikuta@chromium.org
    
    Change-Id: I340068b6f84583af89fa7c75d43566acc2b61537
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1094369
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352811Reviewed-by: default avatarBret Sepulveda <bsep@chromium.org>
    Commit-Queue: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#797596}
    84a0a6bf
kill_posix.cc 5.24 KB