• Will Harris's avatar
    Fix RVAToAddr to correctly handle 64-bit thunk pointers. · 84a70491
    Will Harris authored
    IMAGE_THUNK_DATA.ForwarderString is 64-bit on 64-bit platforms.
    
    ../../base/win/pe_image.cc(422,36):  error: implicit conversion loses integer precision: 'ULONGLONG' (aka 'unsigned long long') to 'DWORD' (aka 'unsigned long') [-Werror,-Wshorten-64-to-32]
              RVAToAddr(name_table->u1.ForwarderString));
              ~~~~~~~~~ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
    ../../base/win/pe_image.cc(504,47):  error: implicit conversion loses integer precision: 'ULONGLONG' (aka 'unsigned long long') to 'DWORD' (aka 'unsigned long') [-Werror,-Wshorten-64-to-32]
                         RVAToAddr(name_table->u1.ForwarderString));
                         ~~~~~~~~~ ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
    
    BUG=588506
    
    Change-Id: I9b6b05611bc3301cf9459f2bf7847975cc2b3c93
    Reviewed-on: https://chromium-review.googlesource.com/1183852Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
    Commit-Queue: Will Harris <wfh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#585290}
    84a70491
pe_image.cc 18.9 KB