• ricea's avatar
    Remove TODO for mime-sniffing of mpeg types. · 84dd027a
    ricea authored
    The following TODO existed in mime_sniffer.cc since 2008:
    
    // TODO(abarth): we don't handle partial byte matches yet
    // MAGIC_NUMBER("video/mpeg", "\x00\x00\x01\xB")
    // MAGIC_NUMBER("audio/mpeg", "\xFF\xE")
    // MAGIC_NUMBER("audio/mpeg", "\xFF\xF")
    
    video/mpeg is not sniffed by Firefox or IE, and is not required to be sniffed by the spec at https://mimesniff.spec.whatwg.org/.
    
    audio/mpeg is already sniffed for the common case where the file starts with an ID3 tag. The uncommon case where it starts with "\xFF\xF." is too broad (it matches the little-endian UTF-16 byte-order-mark), and is not required by the spec.
    
    Remove the TODO.
    
    TEST=net_unittests
    BUG=
    
    Review URL: https://codereview.chromium.org/1138483004
    
    Cr-Commit-Position: refs/heads/master@{#329317}
    84dd027a
mime_sniffer.cc 36.9 KB