• Avery Musbach's avatar
    tablet: Hide/show mouse on enter/exit tablet, not on block/unblock input · 8502842e
    Avery Musbach authored
    The mouse cursor will be hidden/shown when entering/exiting tablet mode,
    instead of when internal touchpad input events are blocked/unblocked.
    Examples:
    1. Detach the internal keyboard/touchpad from a nocturne. It enters
    tablet mode, but it does not block internal touchpad input events,
    because the internal touchpad is gone. With the present CL, the mouse
    cursor will be hidden. Without the present CL, it is not.
    2. Attach an external pointing device and then flip the lid to tablet
    position and back to clamshell position. Without the present CL, the
    mouse cursor will be hidden when you flip to tablet position, and then
    shown when you flip back to clamshell position. With the present CL,
    that will not happen.
    
    Fixed: 1123687, 1133031
    Test: All/TabletModeControllerTest.ShowAndHideMouseCursorTest/?
    Change-Id: I22cb7d3ffeb6d62b1b74f182c4bbe73b2338ff2b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436325Reviewed-by: default avatarMitsuru Oshima <oshima@chromium.org>
    Reviewed-by: default avatarAhmed Fakhry <afakhry@chromium.org>
    Commit-Queue: Avery Musbach <amusbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#813819}
    8502842e
touch_devices_controller.cc 6.07 KB