• Xi Cheng's avatar
    Revert "Upgrade image file management for Win 10 native notification" · 85090799
    Xi Cheng authored
    This reverts commit b011ab56.
    
    Reason for revert: caused test failures -- see crbug/897352
    
    Original change's description:
    > Upgrade image file management for Win 10 native notification
    > 
    > This CL makes the following changes:
    > 1) Change to run image folder cleanup after Chrome startup using a background
    >    task, rather than running it at Chrome shutdown using a high priority task.
    > 2) Retain the image folder to avoid deleting and creating it repeatedly.
    > 3) Remove <subdir> from the full path for the temp file, which is unnecessary.
    > 4) Delete the temp files in batch.
    > 
    > These changes have the following benefits:
    > 1) Fix the issue of Chrome shutdown being blocked by image file IO for some users
    >    as in the current implementation.
    > 2) Save some disk IO related to the sub-directories in the image folder and the
    >    image folder itself.
    > 3) Avoid creating a deletion task for each file, otherwise the overhead can be
    >    large when there is a steady stream of notifications coming rapidly.
    > 
    > Bug: 888276
    > Change-Id: I214680aa00bd7f19e84e207e82ada553583a094b
    > Reviewed-on: https://chromium-review.googlesource.com/c/1260498
    > Commit-Queue: Xi Cheng <chengx@chromium.org>
    > Reviewed-by: Ilya Sherman <isherman@chromium.org>
    > Reviewed-by: Greg Thompson <grt@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#601227}
    
    TBR=isherman@chromium.org,finnur@chromium.org,grt@chromium.org,chengx@chromium.org
    
    Change-Id: Ie79e62373c0076346499e450e48c2d16b55c6dc4
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 888276, 897352
    Reviewed-on: https://chromium-review.googlesource.com/c/1292834Reviewed-by: default avatarXi Cheng <chengx@chromium.org>
    Commit-Queue: Xi Cheng <chengx@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#601376}
    85090799
histograms.xml 4.81 MB
The source could not be displayed because it is larger than 1 MB. You can load it anyway or download it instead.