GitLab

This reverts commit 7a8180fa.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 739179 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vN2E4MTgwZmFiYzQ0MGE0MWIzMTI2Y2UzNjc1ZmI1ZDg4MTRmYjgxNQw

Sample Failed Build: https://ci.chromium.org/b/8889148211576341952

Sample Failed Step: interactive_ui_tests

Sample Flaky Test: BrowserFocusTest.NavigateFromOmnibox

Original change's description:
> Focus tab earlier for browser-initiated, //chrome-layer navigations.
> 
> This CL changes how navigations result in focusing the tab contents:
> 
> 1. Browser-initiated navigations:
>    - Before this CL: Focus done in FocusTabAfterNavigationHelper
>      which covers both OpenURL and BeginNavigation code paths.
>    - After this CL: Focus done in Browser::UpdateUIForNavigationInTab
>      (similarly to pre-r737502) which covers only the OpenURL code path.
> 
> 2. NTP-initiated navigations:
>    - No change: Focus done in FocusTabAfterNavigationHelper.
> 
> This CL makes sure that the text in the Omnibox is not temporarily
> selected during a navigation, by ensuring that the Omnibox is not
> focused when OmniboxViewViews::Update runs (see also
> https://crbug.com/1048742#c4 and #c5 and #c7).  Regression tests
> are added for this problem.
> 
> This CL also makes sure that DevTools-initiated navigations
> (browser-initiated navigations which go through the BeginNavigation
> path) do not result in focus changes (see also
> https://crbug.com/1048591).
> 
> This CL might also (speculating here) address the performance bugs
> tracked in bugs 1048333, 1048556, 1048565, 1048988, 1048988.
> 
> Fixed: 1048742, 1048591
> Bug: 1048333, 1048556, 1048565, 1048988, 1048988
> Change-Id: Ia00cd9143991c260615663fae06f096e9d7cf0f7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040234
> Commit-Queue: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739179}


Change-Id: Ic3ddf4de6a92eecf9175d91b572dacb2b436f371
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1048333, 1048556, 1048565, 1048988, 1048988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042929
Cr-Commit-Position: refs/heads/master@{#739279}