• Thomas Tellier's avatar
    Reland "Add a pop-up for Chrome OS secondary login screen" · 853052eb
    Thomas Tellier authored
    This reverts commit 253d9157.
    
    Reason for revert: Need to implement the feature
    
    Original change's description:
    > Revert "Add a pop-up for Chrome OS secondary login screen"
    > 
    > This reverts commit 3e085ec3.
    > 
    > Reason for revert: Test is crashing with a segmentation fault
    > 
    > Original change's description:
    > > Add a pop-up for Chrome OS secondary login screen
    > > 
    > > Bug: 1066489
    > > Change-Id: I5af5d0ab745176572dfa01cb02e6d45ac1b27c99
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303429
    > > Commit-Queue: Thomas Tellier <tellier@google.com>
    > > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
    > > Reviewed-by: Thomas Tellier <tellier@google.com>
    > > Cr-Commit-Position: refs/heads/master@{#805844}
    > 
    > TBR=antrim@chromium.org,raleksandrov@google.com,tellier@google.com
    > 
    > Change-Id: I35550da66bba011cb35b9e50d38b4b02b572ce29
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1066489
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404061
    > Reviewed-by: K. Moon <kmoon@chromium.org>
    > Commit-Queue: K. Moon <kmoon@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#805939}
    
    TBR=antrim@chromium.org,raleksandrov@google.com,kmoon@chromium.org,tellier@google.com
    
    # Not skipping CQ checks because this is a reland.
    
    Bug: 1066489
    Change-Id: Id1eebd7da875a5c12f5f4821875b4590f7e76331
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404350Reviewed-by: default avatarK. Moon <kmoon@chromium.org>
    Reviewed-by: default avatarThomas Tellier <tellier@google.com>
    Commit-Queue: Thomas Tellier <tellier@google.com>
    Cr-Commit-Position: refs/heads/master@{#806288}
    853052eb
BUILD.gn 110 KB