GitLab

TempFile::CheckValidity() only ever returned PP_OK or PP_ERROR_FAILED.
We can replace its result with a bool.

This makes it clear that ReportPpapiError() was only ever called with
PP_ERROR_FAILED, so we can remove it and call ReportNonPpapiError()
instead.

We can also move an error check into NexeReadDidOpen(), instead of
having its callers check.

BUG=302078
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)

Review URL: https://codereview.chromium.org/1608313002

Cr-Commit-Position: refs/heads/master@{#370518}