• Christoph Schwering's avatar
    Revert "Prevent deadlock by checking kRestrictGoogleWebVisibility sooner." · 85f072c1
    Christoph Schwering authored
    This reverts commit b622082c.
    
    Reason for revert: The CL seems to cause flakiness of
    VariationsHttpHeadersBrowserTestWithRestrictedVisibility.TestRestrictGoogleWebVisibilityInThirdPartyContexts, crbug.com/1133291
    
    Original change's description:
    > Prevent deadlock by checking kRestrictGoogleWebVisibility sooner.
    >
    > More specifically, check the feature's state after field trials have
    > been created from the variations seed and before the variations
    > header is updated.
    >
    > Checking the state for the first time in
    > VariationsIdsProvider::GenerateBase64EncodedProto() could cause a
    > deadlock.
    >
    > Bug: 1094303
    > Change-Id: I53fe3446e3a4567d4b9122b54642b5744eb8b46e
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431556
    > Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
    > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    > Reviewed-by: Jesse Doherty <jwd@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#811566}
    
    TBR=jwd@chromium.org,asvitkine@chromium.org,caitlinfischer@google.com
    
    Change-Id: I8cbc093f9bd9d978a13eb881d7dc319309a808fe
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1094303, 1133291
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438057Reviewed-by: default avatarChristoph Schwering <schwering@google.com>
    Commit-Queue: Christoph Schwering <schwering@google.com>
    Cr-Commit-Position: refs/heads/master@{#811654}
    85f072c1
variations_ids_provider.cc 15.8 KB