GitLab

When Steady State Elisions is on, there's currently the following bug:

When the user clicks the Omnibox (and selects everything), then Alt-Tabs
out of the window, and Alt-Tabs back in, the selection changes from
select-all to a cursor at the beginning of the Omnibox.

This CL fixes the bug and adds a test to prevent regression. The bug
was caused by some old code in OmniboxEditModel that should have been
deleted a while ago.

It also refactors the test a bit to make the focus and blur fake events
more robust.

It also updates the OmniboxViewViews::OnFocus method to be suitable for
usage within tests (rather than overriding and defining a fake one).

Bug: 797354
Change-Id: I4516455cf81e4097f27605f52a669f01f7c17f61
Reviewed-on: https://chromium-review.googlesource.com/1013209
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551137}