• Pavol Marko's avatar
    Revert "Reload the PDF accessibility tree on layout changes" · 86b19038
    Pavol Marko authored
    This reverts commit 2d0cae27.
    
    Reason for revert: The CL caused test failures on PDFExtensionTestWithParam.PdfAccessibilityTextRunCrash
    Example failure:
    https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/10202
    The test is only enabled with gn arg is_chrome_branded = true which explains why it got missed in CQ.
    (when reproing locally, I also ran into crbug.com/1152752 , so if you want to repro make sure to turn dchecks off :-D )
    
    Original change's description:
    > Reload the PDF accessibility tree on layout changes
    >
    > Currently, any layout changes applied to the PDF document (i.e. page
    > rotation or two-up view) after the accessibility tree has loaded does
    > not update the page bounds.
    >
    > Because the accessiblity tree has read-only nodes, the only way to
    > resolve the issue is to reload all the nodes of the tree on each layout
    > change.
    >
    > Note: This CL only fixes page bounds and positions. The bounds of page
    > content such as text or annotations still do not rotate with the rest
    > of the document. Those issues will be fixed in a follow-up.
    >
    > Bug: 1150665
    > Change-Id: I2fbf2cb26f38ee3fed076333c0b224a8ede7947e
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553217
    > Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
    > Reviewed-by: Ankit Kumar 🌪️ <ankk@microsoft.com>
    > Reviewed-by: Raymes Khoury <raymes@chromium.org>
    > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    > Reviewed-by: Tom Sepez <tsepez@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#830918}
    
    TBR=raymes@chromium.org,dmazzoni@chromium.org,tsepez@chromium.org,dhoss@chromium.org,ankk@microsoft.com
    
    Change-Id: I6c2946592cfcb496c6ed2cd3de6610e2d7c64902
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1150665
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560263Reviewed-by: default avatarPavol Marko <pmarko@chromium.org>
    Commit-Queue: Pavol Marko <pmarko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#830971}
    86b19038
pdf_accessibility_tree.cc 63.6 KB