• Scott Violet's avatar
    weblayer: forces top-view shown during load · 86c32d98
    Scott Violet authored
    Prior to this patch, if the top-view was configured to only expand
    at top, then on page load the top-view would not be shown.
    
    During a load if current_browser_controls_visibility_constraint_ is BOTH,
    then cc is called with current and constraints of BOTH. cc doesn't do
    anything in this case. As we need to ensure the top-view is shown in
    this scenario this changes the code to supply SHOWN.
    
    This code path is only hit if top-view is configured to
    only-expand-at-top, as when only-expand-at-top is false,
    current_browser_controls_visibility_constraint_ is set to SHOWN.
    
    I experimented with fixing in cc, but cc has no notion of page
    loading. So, this fix is better done in WebLayer.
    
    BUG=1135964
    TEST=BrowserControlsTest
    
    Change-Id: I7834ade5cd80de6946af0c2f917fb0ea1996e1f0
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476725
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: default avatarBo <boliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#817985}
    86c32d98
tab_impl.cc 48.1 KB