• Andrey Kosyakov's avatar
    Reland "Move browser_protocol.pdl to third_party/blink/public/devtools_protocol" · 87083177
    Andrey Kosyakov authored
    This reverts commit ec3649f6.
    
    Reason for revert: attempt to re-land the original change while maintaining protocol copy where devtools-frontend expects to find it.
    
    TBR=dgozman@chromium.org,tapted@chromium.org,caseq@chromium.org,pfeldman@chromium.org,jochen@chromium.org
    
    Original change's description:
    > Revert "Move browser_protocol.pdl to third_party/blink/public/devtools_protocol"
    >
    > This reverts commit 3e9d66eb.
    >
    > Reason for revert: Widespread bot failures for Step "isolate tests"
    >
    > error like:
    >
    > isolate: isolate /b/s/w/ir/cache/builder/src/out/Release/devtools_type_check.isolate: partitioning deps: lstat /b/s/w/ir/cache/builder/src/third_party/blink/renderer/core/inspector/browser_protocol.pdl: no such file or directory
    >
    > Bug: 1028446
    >
    > Original change's description:
    > > Move browser_protocol.pdl to third_party/blink/public/devtools_protocol
    > >
    > > Bug: 1018108
    > >
    > > This still retains a copy of protocol.json for compatibility with
    > > devtools front_end.
    > > Also, remove a presubmit for front-end compilation upon a change to PDL
    > > since the front-end is in another repository now.
    > >
    > > Change-Id: I2faea62feca80776d2fc0a0b4ea00a90439ae005
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898538
    > > Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
    > > Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#718903}
    >
    > TBR=dgozman@chromium.org,caseq@chromium.org,pfeldman@chromium.org,jochen@chromium.org
    >
    > Change-Id: I39435e4be7dde62ffd48d1f72a0ecbbac9165ae1
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1018108
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935479
    > Reviewed-by: Trent Apted <tapted@chromium.org>
    > Commit-Queue: Trent Apted <tapted@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#718977}
    
    Change-Id: Iae5bdbd809cea60fe566b1ebf160836982c4cfcd
    Bug: 1028446, 1018108
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937860
    Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
    Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
    Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#719401}
    87083177
BUILD.gn 1.19 KB