• Stephen McGruer's avatar
    Revert "Narrow the scope of page pause when printing." · 87248e6a
    Stephen McGruer authored
    This reverts commit f0f5ad44.
    
    Reason for revert: Tentative revert for suspect of BackForwardCachePrintBrowserTest.DisableCaching failure; see https://crbug.com/1115515
    
    If this does not resolve the issue, I will reland the CL (with apologies! :))
    
    Original change's description:
    > Narrow the scope of page pause when printing.
    > 
    > In the current implementation, sometimes the scope of a page's "pause"
    > is too wide compared to the definition in the spec [1], and sometimes it
    > does not pause at all. So narrow the scope to better conform to the
    > spec, and apply it consistently to all possible ways users can print.
    > 
    > This is based on an earlier CL [2] which only did this for printing with
    > the system dialog, but not for Print Preview. Some of the trickier cases
    > handled, which require unpausing, are:
    > - Navigations while previewing.
    > - Printing selections, which require a navigation.
    > 
    > [1] https://html.spec.whatwg.org/C/#printing-steps
    > [2] https://crrev.com/c/1669250
    > 
    > Bug: 956832
    > Change-Id: I9bf274fcfb70eefe896fbbae9ce13a88b6f4dfc0
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338819
    > Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    > Reviewed-by: Kent Tamura <tkent@chromium.org>
    > Commit-Queue: Lei Zhang <thestig@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#797120}
    
    TBR=thestig@chromium.org,yukishiino@chromium.org,tkent@chromium.org
    
    Change-Id: I3518cb22f1b19fb4a2942c46fbcd9e7326d20863
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 956832, 1115515
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352430Reviewed-by: default avatarStephen McGruer <smcgruer@chromium.org>
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#797234}
    87248e6a
print_render_frame_helper.h 23.4 KB