• danakj's avatar
    Cleanups in RenderWidget initialization/destruction code · 872a96a1
    danakj authored
    Make Init() private, add an InitForPepperFullscreen() and
    InitForMainFrame() that RenderWidgetFullscreenPepper and RenderViewImpl
    and RenderFrameImpl make use of. Now every callsite declares its
    intentions.
    
    Remove comments about RenderWidget being self-referencing, it is not
    ref counted any longer.
    
    Use render_widget_ instead of GetWidget() in RenderViewImpl. It is
    the same thing but it makes code more clear about where it is ending
    up. Especially interesting is the lines:
    
      RenderWidget* closing_widget = render_widget_.get();
      closing_widget->Close(std::move(render_widget_));
    
    Some cleanups in the RenderWidgetFullscreenPepper code around
    construction and use of the new RenderWidget Init api. And also
    in RenderFrameImpl.
    
    R=avi@chromium.org
    
    Bug: 419087
    Change-Id: Ifa1bc6b63d57b557ea14a21cb45e5b42cb903df2
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811519
    Commit-Queue: danakj <danakj@chromium.org>
    Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#697785}
    872a96a1
render_widget_fullscreen_pepper.cc 14.8 KB