• Hui Yingst's avatar
    Move 4 attributes from OutOfProcessInstance to PdfViewPluginBase. · 8737b36a
    Hui Yingst authored
    In OutOfProcessInstance, the attributes `zoom_`, `device_scale_`,
    `first_paint_` and `in_paint_` are used for drawing graphics, and they
    will be used by PdfViewWebPlugin in the future. Therefore this CL moves
    them into PdfViewPluginBase so that they can be shared between
    PdfViewWebPlugin and OutOfProcessInstance, and adds accessors and
    mutators for them.
    
    Meanwhile, to avoid providing pointer access to `in_paint_`, this CL
    moves the definition of OnPaint() into PdfViewPluginBase while keeping
    the majority of its functionality wrapped in DoPaint(), which is
    delegated to PdfViewPluginBase's derived classes.
    
    Bug: 1140629
    Change-Id: Ie2439d883836d5755ca4d86291ae9ccecc1b07a8
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601039Reviewed-by: default avatarK. Moon <kmoon@chromium.org>
    Commit-Queue: Hui Yingst <nigi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#839202}
    8737b36a
pdf_view_web_plugin.h 6.52 KB