• Martin Kreichgauer's avatar
    Fill in makeCredential implementation gaps in caBLEv2 authenticator · 877a199e
    Martin Kreichgauer authored
    When handling makeCredential requests in the caBLEv2 authenticator, pass
    request arguments from the native side where they are unmarshaled over
    to the Java side, so they can be used to construct the GMSCore FIDO API
    request. When receiving a response from the FIDO API, pass response
    parameters back to native code where they are converted into a CTAP
    response. Both sides were previously using hard-coded fake data.
    
    Move CtapMakeCredentialRequest and CtapGetAssertionRequest parsing code
    out of VirtualCtap2Device so that caBLEv2 authenticator native code can
    reuse them. Add a Parse() factory method to AttestationObject because
    the native code needs to parse the CBOR Java response from Java in order
    to convert it into a CTAP message.
    
    Also switch native code to make use of //base/android JNI type
    conversion helpers throughout.
    
    Bug: 1002262
    Change-Id: Ie24adec8c2b8f64e4330aa1fc4b3bf8a273617e7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109037
    Commit-Queue: Martin Kreichgauer <martinkr@google.com>
    Reviewed-by: default avatarAdam Langley <agl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#751907}
    877a199e
ctap_get_assertion_request.cc 6.84 KB