• Dongseong Hwang's avatar
    webgl, cros: hardware overlay requires BGR native GBM · 8780d036
    Dongseong Hwang authored
    RGB texture backed by native GMB cannot be bound to FBO on Intel, but BGR
    texture backed by native GMB can be bound.
    
    When GL_EXT_texture_format_BGRA8888 is supported, as-is chromium doesn't allow
    BGRA and glTexStorage2D together, because the extensions doesn't define BGRA8
    storage format.
    
    Now native GBM needs BGR for WebGL hardware overlay, so this CL allows
    both of them for WebGL context.
    
    It's safe because WebGL API doesn't expose BGRA, and DrawingBuffer never use
    glTexStorage2D(BGRA8).
    
    BUG=746069
    TEST=run WebGL Aquarium on eve
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
    
    Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    Change-Id: I0e74f738beff16826dcc7af5684791712923851c
    Reviewed-on: https://chromium-review.googlesource.com/576967
    Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com>
    Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
    Reviewed-by: default avatarDongseong Hwang <dongseong.hwang@intel.com>
    Cr-Commit-Position: refs/heads/master@{#488461}
    8780d036
feature_info.cc 70.3 KB