• Vaibhav Raheja's avatar
    arcvm: Not booting in the case of NEED_POWERWASH. · 879b8a61
    Vaibhav Raheja authored
    Currently, ARCVM is not booting in the case of
    AdbSideloadResponseCode::NEED_POWERWASH. AdbSideloadResponseCode can
    return 3 possible values:
    1. SUCCESS - Here, the sideloading flag should be setup
    accordingly.
    2. FAILED - Because of an unsuccessful response, here we stop
    the upgradation of ARC and log an error.
    3. NEED_POWERWASH - Currently, this is implemented
    incorrectly - replicating the above FAILED case.
    NEED_POWERWASH occurs when bootlockbox has an undefined
    NVSpace - http://shortn/_3dSlMMlZBc.
    
    The scope of this CL is to upgrade the ARC in NEED_POWERWASH
    scenario while ensuring that is_enabled_sideloading flag is
    set to 0, without going into the implementation details of
    Powerwash.
    
    BUG=b:175420640
    
    TEST=Tested with following:
    1. Put the device to be in Need_Powerwash case.
    2. android-sh on the device post-login.
    
    Unit Test:
    testing/xvfb.py ./out/Debug/components_unittests
    --gtest_filter="ArcVmClientAdapterTest.*"
    
    Change-Id: Ic2864fbb065672db595b774e744f1a2423385f87
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587566
    Commit-Queue: Yusuke Sato <yusukes@chromium.org>
    Reviewed-by: default avatarRyo Hashimoto <hashimoto@chromium.org>
    Reviewed-by: default avatarYusuke Sato <yusukes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#837936}
    879b8a61
fake_session_manager_client.cc 28.1 KB