• Robert Liao's avatar
    Specify Fixed Background Tab Colors in the IncreasedContrastThemeSupplier · 88085d16
    Robert Liao authored
    The IncreasedContrastThemeSupplier previously had these colors:
    
                         Frame        Tab Bkgnd   Contrast
                         Color        Text           Ratio
    Light Mode Inactive  Gray         Black           5.92
    Light Mode Active    Dark Gray    Black           2.15
    Dark Mode Inactive   Gray         White           3.54
    Dark Mode Active     Dark Gray    White           9.73
    
    This doesn't really make sense as the frame color doesn't change with
    light/dark mode. Previously, this worked accidentally as
    BlendForMinContrast would save us. After http://crrev.com/687315 , the
    IncreasedContrastThemeSupplier was no longer blended, revealing the bug.
    
    Since the frame color is invariant with respect to light/dark mode, the
    new colors are as follows:
    
                         Frame        Tab Bkgnd   Contrast
                         Color        Text           Ratio
    Light Mode Inactive  Gray         Black           5.92
    Light Mode Active    Dark Gray    White           9.73
    Dark Mode Inactive   Gray         Black           5.92
    Dark Mode Active     Dark Gray    White           9.73
    
    BUG=1046818
    
    Change-Id: Ic9452154f833f471a51e2ea6eacfb49f10cf1232
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042144Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
    Commit-Queue: Robert Liao <robliao@chromium.org>
    Auto-Submit: Robert Liao <robliao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#739237}
    88085d16
increased_contrast_theme_supplier.cc 2.07 KB