• Khushal's avatar
    cc: Avoid SkData malloc and copy for SkTextBlobs. · 883ad990
    Khushal authored
    PaintOpReader::Read for SkData is used by 2 code-paths, deserializing
    SkTextBlobs and AnnotateOps. While AnnotateOp needs to copy the SkData,
    the copy for SkTextBlobs is completely unnecessary.
    
    This also uncovered skia caching keyed on text blob ids in
    GrAtlasTextContext, which we'll miss in OOP by re-serializing the text
    blobs each time. This should be addressed by caching these on the
    service side in a follow up.
    
    R=enne@chromium.org
    BUG: 821584
    
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
    Change-Id: I77b47621e0f0bca225377968b02ca5f401804bc0
    Reviewed-on: https://chromium-review.googlesource.com/959439
    Commit-Queue: Khushal <khushalsagar@chromium.org>
    Reviewed-by: default avatarenne <enne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#543025}
    883ad990
paint_op_writer.cc 21.9 KB