• David Bokan's avatar
    Add DumpWithoutCrash for slow Mac KeyPress events · 888e67db
    David Bokan authored
    Add a DumpWithoutCrash to KeyPress events where the timestamp of the OS
    differs from the current time by more than 5 seconds. We see in UMA that
    we often see events in the 95% percentile reaching many seconds of
    difference. Hopefully the crash stacks will reveal something about
    what's causing this.
    
    A previous iteration of this investigation in
    https://crrev.com/c/2111782 showed that we sometimes redispatch events
    that have been reinjected back from the renderer. This should never
    happen. This CL adds crash keys to dump some of the related app state
    to help explain how this happens.
    
    However, not all such stack traces showed reinjection so that can't be
    the cause of all these bad timestamps. This CL also adds some timing
    information to the existing crash key in NSApp:sendEvent which might
    reveal something.
    
    Bug: 1039833
    Change-Id: I90a8bb210debc8e9f0fcfba23a566200de72e9c2
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144627Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
    Commit-Queue: David Bokan <bokan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#758871}
    888e67db
command_dispatcher.mm 10.1 KB