GitLab

VpnServiceFactory::GetInstance() and
VpnServiceFactory::GetForBrowserContext() are declared at the extensions
layer but only defined by its embedders (chrome and shell). This is
incorrect since it means any targets depending on extensions without
defining these methods will fail to link. Prevent this by providing an
implementation at the extensions/ layer and removing the embedder
implementations.

BUG=981112

Change-Id: Ic6af1b8e95b7bf569fd5791031facd8e30f52ba1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557222
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831073}