-
Karandeep Bhatia authored
Since r786851, the docserver integration test is hanging causing presubmits to fail. Also, the cron script which we use to update the docserver is hanging. This is because r786851 added dependencies on behavior features. However behavior features are not accounted for in features_bundles.py which is used to resolve feature characteristics like channel, platform etc. Since the code in the file expects that all features will eventually be resolved, it keeps running indefinitely. To fix: - Ensure behavior features are ignored for the purpose of evalauting feature characteristics for the docserver. - Break out of the loop in GetFeatures if no new features are resolved after a top level iteration. This'll ensure that the script terminates eventually. Also, log an error if any features are left unresolved. Other fixes: - Delete cloudPrintPrivate.html. It was causing presubmit to fail since beginning r785624, cloudPrintPrivate is disabled for extensions. - Disable pylint checking in chrome/common/extensions/docs/server2/PRESUBMIT.py. There are multiple failures there already and it is causing the presubmit step to timeout. BUG=1103846, 1105211 TEST=python chrome/common/extensions/docs/server2/integration_test.py -- apps/developerPrivate doesn't hang Change-Id: I640ea35a66ecd863e39ca7b9b2e3e5469bfae2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296866Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#788844}
88f8ca14