• Katie D's avatar
    Autoclick menu supports RTL languages. · 88faf3bf
    Katie D authored
    Autoclick menu icons should not be mirrored in RTL languages because
    they have a directionality: The click types correspond to mouse buttons
    left and right, and the positions correspond to corners of the screen.
    
    Also adds a default screen position. This will be the same as where
    the volume and brightness sliders show up on the screen in LTR/RTL
    languages, and change with language direction. However, as soon as the
    user explicitly picks another position using the autoclick menu
    position button, the position will be fixed no matter if the user
    changes their system language direction.
    See go/chromeos-dwell-menu-design under the "Positioning" subheading.
    
    Bug: 958998
    Change-Id: I28b3bf44b1f9081d6709e0b8255913f69ccac3c5
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594654
    Commit-Queue: Katie Dektar <katie@chromium.org>
    Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
    Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
    Reviewed-by: default avatarTetsui Ohkubo <tetsui@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#657375}
    88faf3bf
autoclick_menu_view.cc 11.6 KB