• Timothy Gu's avatar
    Revert "Reland "bindings: Implement timers with V8Function"" · 892067a4
    Timothy Gu authored
    This reverts commit 17f4e7d2.
    
    Reason for revert: Still breaks ASAN
    
    Original change's description:
    > Reland "bindings: Implement timers with V8Function"
    > 
    > This is a reland of 254369a5. It addresses bug
    > 888025 by adding ASAN test expectations, as the relevant V8 feature does not
    > yet support running on ASAN builds.
    > 
    > Original change's description:
    > > bindings: Implement timers with V8Function
    > >
    > > This fixes bug 866610 by using the IDL infrastructure to properly enter
    > > the v8::Context before calling the registered callback.
    > >
    > > Also ensure eager finalization of ScheduledAction in DOMTimer to
    > > prevent a memory leak. Added two more effective DCHECKs to confirm.
    > >
    > > Bug: 866610
    > > Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1
    > > Reviewed-on: https://chromium-review.googlesource.com/1220486
    > > Reviewed-by: Nate Chapin <japhet@chromium.org>
    > > Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    > > Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    > > Commit-Queue: Timothy Gu <timothygu@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#593108}
    > 
    > TBR=japhet@chromium.org
    > 
    > Bug: 866610, 888025
    > Change-Id: Iee5c1d6917ad7770383e06a425f96000835a663a
    > Reviewed-on: https://chromium-review.googlesource.com/c/1239624
    > Reviewed-by: Nate Chapin <japhet@chromium.org>
    > Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    > Reviewed-by: Kentaro Hara <haraken@chromium.org>
    > Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    > Commit-Queue: Timothy Gu <timothygu@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#601830}
    
    TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,japhet@chromium.org,timothygu@chromium.org
    
    Change-Id: Ie4f45dfcc1adcc2ac3469eab99dba813723288f4
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 866610, 888025
    Reviewed-on: https://chromium-review.googlesource.com/c/1296057
    Commit-Queue: Timothy Gu <timothygu@chromium.org>
    Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#601864}
    892067a4
ASANExpectations 6.19 KB